Skip to content

Resolves #48 Make the PropertyFetcher case insensitive #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

markvincze
Copy link
Contributor

Details about the issue in #48

Do I need to do anything else for the release (for example bumping the version, etc.), or everything else is taken care of by the CI build?

@austinlparker
Copy link
Member

CI takes care of versioning when we make a release tag. Thanks for the fix!

@austinlparker austinlparker merged commit 7f292f6 into opentracing-contrib:master Aug 21, 2019
@markvincze markvincze deleted the adjust-propertyfetcher-aspnetcore3 branch August 21, 2019 14:43
@yelob
Copy link
Contributor

yelob commented Sep 5, 2019

Any timeline on getting a release that contains this fix?

@rwkarg
Copy link
Contributor

rwkarg commented Sep 5, 2019

Looks like release 0.6.1 was just created with this change in it!

@austinlparker
Copy link
Member

It was! Happy Thursday. :)

@yelob
Copy link
Contributor

yelob commented Sep 5, 2019

Woo hoo! Thanks!

@yelob
Copy link
Contributor

yelob commented Sep 6, 2019

Thanks again for creating the release. At what point will that get pushed to nuget?

@austinlparker
Copy link
Member

I published it a few minutes ago, so it should show up within the hour. Thanks for your patience!

@yelob
Copy link
Contributor

yelob commented Sep 6, 2019

Awesome, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants