Skip to content

STOR-1408: Chore: Update ibm-vpc-block-csi-driver to the latest release #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 22, 2023

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Oct 31, 2023

https://issues.redhat.com/browse/STOR-1408

This rebases the driver on the v5.2.4 upstream release, bringing in the following changes since v5.1.5

Diff to upstream v5.2.4: kubernetes-sigs/ibm-vpc-block-csi-driver@v5.2.4...dobsonj:ibm-vpc-block-csi-driver:rebase-v5.2.4

cc @openshift/storage

ambiknai and others added 17 commits June 8, 2023 22:42
…gs#134)

* Converting controller server statefulset to deployment

* Ignore CVE

* Addressing comments

* Removing duplicate ignore CVEs
kubernetes-sigs#151)

* Update of fix for snapshot custom retry and snapshot enable/disable feature

* Make file changes

* fmt fix
* configurable volume attachment limit

* volumeAttchLimit as flag

* change default

* use os env variable

* remove MaxAllowedVolumesPerNode

* log statements
Add 'nouuid' mount option when mounting xfs to disable checks of filesystem
UUIDs. This allows a xfs volume and its clone (or restored snapshot) to be
mounted on the same node - they will have the same UUID.
* Fix for CVE CVE-2023-39325

* travis fix

* travis fix

* Golang upgrade

* Updating golang version

* Updating lint version

* lint fix
We don't want custom templates or dependabots in OpenShift forks.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2023

@dobsonj: This pull request references STOR-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-1408

This rebases the driver on the v5.2.4 upstream release, bringing in the following changes since v5.1.5

Diff to upstream v5.2.4: kubernetes-sigs/ibm-vpc-block-csi-driver@v5.2.4...dobsonj:ibm-vpc-block-csi-driver:rebase-5.2.4

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2023

@dobsonj: This pull request references STOR-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-1408

This rebases the driver on the v5.2.4 upstream release, bringing in the following changes since v5.1.5

Diff to upstream v5.2.4: kubernetes-sigs/ibm-vpc-block-csi-driver@v5.2.4...dobsonj:ibm-vpc-block-csi-driver:rebase-v5.2.4

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Oct 31, 2023

/retest

3 similar comments
@dobsonj
Copy link
Member Author

dobsonj commented Nov 6, 2023

/retest

@chao007
Copy link

chao007 commented Nov 7, 2023

/retest

@dobsonj
Copy link
Member Author

dobsonj commented Nov 7, 2023

/retest

Copy link

openshift-ci bot commented Nov 8, 2023

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi c0732f5 link false /test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Nov 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@chao007
Copy link

chao007 commented Nov 14, 2023

  PASS OCP-64186 Author:ropatil [CSI-Driver] check the storage volume attach failure alert [Serial]
  PASS OCP-64289 Author:chaoyang [Storageclass] Volume expand failed when nodeexpandsecret is absent
  PASS OCP-64707 Author:rdeore [CSI-Driver] [Dynamic PV] [Filesystem default] ReadWriteOncePod volume should be successfully mounted when consumed by a single pod with multiple containers
 PASS OCP-64157 Author:rdeore [CSI-Driver] [Dynamic PV] [Filesystem default] ReadWriteOncePod volume will succeed mounting when consumed by a single pod on a node, and will fail to mount when consumed by second pod
 PASS OCP-64158 Author:rdeore [CSI-Driver] [Dynamic PV] [Filesystem default] ReadWriteOncePod volume will fail to mount when consumed by second pod on a different node
 PASS OCP-64159 Author:rdeore [CSI-Driver] [Dynamic PV] [Filesystem default] ReadWriteOncePod volume will succeed mounting when consumed by a second pod as soon as first pod is deleted
 PASS OCP-64160 Author:rdeore [CSI-Driver] [Dynamic PV] [Filesystem default] High-priority pod requesting a ReadWriteOncePod volume thats already in-use will result in the preemption of the pod previously using the volume
PASS OCP-64161 Author:rdeore [CSI-Driver] [Dynamic PV] [Filesystem default] Low-priority pod requesting a ReadWriteOncePod volume thats already in-use will result in it being Unschedulable
PASS OCP-27733 Author:chaoyang [CSI-Driver] [Snapshot] [Retain deletionPolicy] [Pre-provision] could re-used snapshotcontent after the snapshot/snapshotcontent deletion
PASS OCP-33606 Author:ropatil [CSI-Driver] [Snapshot] volumesnapshot instance could be deleted even if the volumesnapshotcontent instances deletionpolicy changed from Delete to Retain

@chao007
Copy link

chao007 commented Nov 17, 2023

{"level":"info","ts":"2023-11-14T11:07:44.485Z","caller":"ibmcsidriver/node.go:296","msg":"Formating and mounting ","RequestID":"bb83985f-2fa7-4fae-8d6f-233d5e3cc169 ","source":"/dev/disk/by-id/virtio-07a7-28daf644-7f59-4","stagingTargetPath":"/var/lib/kubelet/plugins/kubernetes.io/csi/vpc.block.csi.ibm.io/4ddbfcb2c5db56ab98e11fb97ef7c926146b1f50f92e96e9539f523264420558/globalmount","fsType":"xfs","options":["nouuid"]}

@chao007
Copy link

chao007 commented Nov 22, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2023

@dobsonj: This pull request references STOR-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/STOR-1408

This rebases the driver on the v5.2.4 upstream release, bringing in the following changes since v5.1.5

Diff to upstream v5.2.4: kubernetes-sigs/ibm-vpc-block-csi-driver@v5.2.4...dobsonj:ibm-vpc-block-csi-driver:rebase-v5.2.4

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link

/label px-approved
/label docs-approved
/override ci/prow/verify-commits

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 22, 2023
Copy link

openshift-ci bot commented Nov 22, 2023

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/verify-commits

In response to this:

/label px-approved
/label docs-approved
/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Nov 22, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 22, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 20f2f6e into openshift:master Nov 22, 2023
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibm-vpc-block-csi-driver-container-v4.15.0-202311231531.p0.g20f2f6e.assembly.stream for distgit ose-ibm-vpc-block-csi-driver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants