fixes: add null check for ngx_stream_lua_get_req in ngx_stream_lua_util #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Svace static analysis tool identified a potential issue in the function
ngx_stream_lua_req_socket()
, where the return value ofngx_stream_lua_get_req
is not checked (line 1936):The return value of
ngx_stream_lua_get_req
(L) was used without a null check. But this function (ngx_stream_lua_get_req
) is typically checked for NULL in most usages. And moreover, dereferencing a potentially NULL pointer can lead to undefined behaviorSo, the solution is to add null-checking: