Skip to content

add exit_worker_by* feature #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 23, 2020
Merged

add exit_worker_by* feature #1682

merged 22 commits into from
Jul 23, 2020

Conversation

rainingmaster
Copy link
Member

@rainingmaster rainingmaster commented Apr 3, 2020 •
edited
Loading

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

The continue for #927 , and add some new test cases.

@thibaultcha @doujiang24 Could you help me check it? Thank you.

And this is the change for lua-resty-core: rainingmaster/lua-resty-core@c787d7d

@doujiang24 doujiang24 requested a review from spacewander April 6, 2020 15:30
@thibaultcha
Copy link
Member

Thanks! For the time being, we are focusing our efforts on the upcoming releases (1.15.8.3 and 1.17.8.1); at least I am - so it may take us some time to review this for now.

spacewander
spacewander reviewed Apr 7, 2020
View reviewed changes
@rainingmaster
Copy link
Member Author

Thanks! For the time being, we are focusing our efforts on the upcoming releases (1.15.8.3 and 1.17.8.1); at least I am - so it may take us some time to review this for now.

It does not matter, I just follow some advice in Q2 like here said

thibaultcha
thibaultcha requested changes Apr 9, 2020
View reviewed changes
@rainingmaster
Copy link
Member Author

@thibaultcha Most review is resolve, could you help me check again, thanks a lot.

@rainingmaster rainingmaster mentioned this pull request Apr 11, 2020
Open
thibaultcha
thibaultcha reviewed Apr 14, 2020
View reviewed changes
thibaultcha
thibaultcha reviewed Apr 14, 2020
View reviewed changes
@moonming moonming mentioned this pull request Apr 28, 2020
Closed
agentzh
agentzh requested changes Jun 5, 2020
View reviewed changes
@agentzh
Copy link
Member

agentzh commented Jun 26, 2020

Guys, is this PR ready for merge?

@agentzh
Copy link
Member

agentzh commented Jun 27, 2020

One thing that is still missing is we should enable APIs which are available in init_worker_by_lua except the timer API? The docs need updating to reflect this.

@rainingmaster
Copy link
Member Author

rainingmaster commented Jun 28, 2020 •
edited
Loading

One thing that is still missing is we should enable APIs which are available in init_worker_by_lua except the timer API? The docs need updating to reflect this.

@agentzh Thanks for your review. I have updated the doc to reflect which APIs are available in exit_worker_by_lua, and both ngx.timer.run_count and ngx.timer.pending_count are marked.

@rainingmaster
Copy link
Member Author

@agentzh @doujiang24 hihi, since 1.17.8 is released, could we merge this PR now?

@doujiang24 doujiang24 mentioned this pull request Jul 14, 2020
Closed
agentzh
agentzh requested changes Jul 20, 2020
View reviewed changes
@rainingmaster rainingmaster merged commit 393c954 into openresty:master Jul 23, 2020
@doujiang24 doujiang24 mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcha thibaultcha thibaultcha requested changes

@agentzh agentzh agentzh requested changes

@doujiang24 doujiang24 doujiang24 approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rainingmaster @thibaultcha @agentzh @doujiang24 @spacewander