Skip to content

chore: document ISR #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2021
Merged

chore: document ISR #986

merged 2 commits into from
Dec 14, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 14, 2021 •
edited
Loading

Summary

Adds docs for ISR. The README PR (#937) adds a section with a link to this doc.

Rendered version

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Fixes #151!!!

image

@ascorbic ascorbic requested a review from tiffafoo December 14, 2021 09:54
@ascorbic ascorbic self-assigned this Dec 14, 2021
@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 61d3e40

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b86f1d81b934000823e3cb

😎 Browse the preview: https://deploy-preview-986--netlify-plugin-nextjs-demo.netlify.app

@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 61d3e40

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b86f1d8cedbe00070727f9

😎 Browse the preview: https://deploy-preview-986--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Dec 14, 2021
@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 61d3e40

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b86f1dc63d370008f1c5e3

😎 Browse the preview: https://deploy-preview-986--netlify-plugin-nextjs-static-root-demo.netlify.app

@cypress
Copy link

cypress bot commented Dec 14, 2021 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 61d3e40
Started Dec 14, 2021 10:20 AM
Ended Dec 14, 2021 10:21 AM
Duration 01:08 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 14, 2021 •
edited
Loading


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 61d3e40
Started Dec 14, 2021 10:20 AM
Ended Dec 14, 2021 10:21 AM
Duration 01:19 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 14, 2021 •
edited
Loading


Test summary

16 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 61d3e40
Started Dec 14, 2021 10:19 AM
Ended Dec 14, 2021 10:22 AM
Duration 02:26 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tiffafoo
tiffafoo previously approved these changes Dec 14, 2021
View reviewed changes
Copy link

@tiffafoo tiffafoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascorbic
Apply suggestions from code review
61d3e40 
Co-authored-by: Tiffany Le-Nguyen <[email protected]>
@ascorbic ascorbic requested a review from tiffafoo December 14, 2021 10:17
@kodiakhq kodiakhq bot merged commit f313dbb into main Dec 14, 2021
@kodiakhq kodiakhq bot deleted the mk/isr-docs branch December 14, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffafoo tiffafoo tiffafoo approved these changes

Assignees

@ascorbic ascorbic

Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for incremental SSG (ISG/ISR)
2 participants
@ascorbic @tiffafoo