Skip to content

fix: warn if publish is "out" #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

fix: warn if publish is "out" #978

merged 2 commits into from
Dec 13, 2021

Conversation

ascorbic
Copy link
Contributor

Summary

If the plugin can't find a build in the publish directory it fails the build with a warning to check that the build command has run and the publish dir is correct. This PR adds specific wording if the publish dir is "out", because that is the old default.

Test plan

Change the publish dir in netlify.toml to "out", then run a build, checking that it fails with a message including Your publish directory is set to "out", but in most cases it should be ".next".

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Fixes #975
image

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 84e359c

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b74c05f418bd0008490a32

😎 Browse the preview: https://deploy-preview-978--netlify-plugin-nextjs-demo.netlify.app

@ascorbic ascorbic self-assigned this Dec 13, 2021
@ascorbic ascorbic requested a review from tiffafoo December 13, 2021 13:14
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Dec 13, 2021
@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 84e359c

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b74c05e0ab2000075cb9db

😎 Browse the preview: https://deploy-preview-978--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/

@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 84e359c

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b74c051c9fde0008be51fd

😎 Browse the preview: https://deploy-preview-978--netlify-plugin-nextjs-static-root-demo.netlify.app

@cypress
Copy link

cypress bot commented Dec 13, 2021



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit e3a4017
Started Dec 13, 2021 1:18 PM
Ended Dec 13, 2021 1:19 PM
Duration 01:19 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 13, 2021



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit e3a4017
Started Dec 13, 2021 1:19 PM
Ended Dec 13, 2021 1:20 PM
Duration 01:08 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 13, 2021



Test summary

16 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit e3a4017
Started Dec 13, 2021 1:18 PM
Ended Dec 13, 2021 1:20 PM
Duration 02:24 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kodiakhq kodiakhq bot merged commit 396f0f8 into main Dec 13, 2021
@kodiakhq kodiakhq bot deleted the mk/warn-out branch December 13, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if publish is set to out
2 participants