-
Notifications
You must be signed in to change notification settings - Fork 89
fix: warn if publish is "out" #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 84e359c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b74c05f418bd0008490a32 😎 Browse the preview: https://deploy-preview-978--netlify-plugin-nextjs-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 84e359c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b74c05e0ab2000075cb9db 😎 Browse the preview: https://deploy-preview-978--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/ |
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 84e359c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b74c051c9fde0008be51fd 😎 Browse the preview: https://deploy-preview-978--netlify-plugin-nextjs-static-root-demo.netlify.app |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Summary
If the plugin can't find a build in the
publish
directory it fails the build with a warning to check that the build command has run and the publish dir is correct. This PR adds specific wording if the publish dir is "out", because that is the old default.Test plan
Change the
publish
dir innetlify.toml
to"out"
, then run a build, checking that it fails with a message includingYour publish directory is set to "out", but in most cases it should be ".next".
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #975

Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.