fix: handle Windows paths correctly #948
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 70d64ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b32e77bcfee00008326a9e 😎 Browse the preview: https://deploy-preview-948--netlify-plugin-nextjs-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 70d64ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b32e771558190007b40d9b 😎 Browse the preview: https://deploy-preview-948--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/ |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 70d64ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b32e779e35270008b8731d 😎 Browse the preview: https://deploy-preview-948--netlify-plugin-nextjs-static-root-demo.netlify.app |
ascorbic
force-pushed
the
mk/windows-page-paths
branch
2 times, most recently
from
739cc2a to
e1de9a7
Compare
ascorbic
force-pushed
the
mk/windows-page-paths
branch
from
e1de9a7 to
387c94d
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
Summary
Changes the way paths are generated for
getPageResolver, because the current way is causing trouble on Windows. Updated the tests so that they're more able to catch this.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #941
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.