Skip to content

chore: convert remaining source files to TypeScript #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 8, 2021

Summary

Converts the final few files to TypeScript

Test plan

  1. Check that the deploy previews work

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

image

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic requested a review from tiffafoo December 8, 2021 12:18
@ascorbic ascorbic self-assigned this Dec 8, 2021
@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 79c55ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b1d1685f42870008bba93b

😎 Browse the preview: https://deploy-preview-939--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/

@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 79c55ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b1d168865d1d00072fd58c

😎 Browse the preview: https://deploy-preview-939--netlify-plugin-nextjs-demo.netlify.app

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Dec 8, 2021
@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 79c55ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b1d168e3a1bf00089517bb

😎 Browse the preview: https://deploy-preview-939--netlify-plugin-nextjs-static-root-demo.netlify.app

tiffafoo
tiffafoo previously approved these changes Dec 9, 2021
Copy link

@tiffafoo tiffafoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 looks great, lil potential improvement comments

i18n,
}: {
netlifyConfig: NetlifyConfig
target: 'server' | 'serverless' | 'experimental-serverless-trace'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sand] Could have a type for this instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next might have one actually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻
image

@kodiakhq kodiakhq bot merged commit 227b026 into main Dec 9, 2021
@kodiakhq kodiakhq bot deleted the mk/ts-files-verif branch December 9, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants