-
Notifications
You must be signed in to change notification settings - Fork 89
chore: convert remaining source files to TypeScript #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 79c55ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b1d1685f42870008bba93b 😎 Browse the preview: https://deploy-preview-939--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/ |
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 79c55ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b1d168865d1d00072fd58c 😎 Browse the preview: https://deploy-preview-939--netlify-plugin-nextjs-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 79c55ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b1d168e3a1bf00089517bb 😎 Browse the preview: https://deploy-preview-939--netlify-plugin-nextjs-static-root-demo.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 looks great, lil potential improvement comments
i18n, | ||
}: { | ||
netlifyConfig: NetlifyConfig | ||
target: 'server' | 'serverless' | 'experimental-serverless-trace' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[sand] Could have a type for this instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next might have one actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Tiffany Le-Nguyen <[email protected]>
Summary
Converts the final few files to TypeScript
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.