Skip to content

chore: add to cypress dashboard for all demo sites #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2021

Conversation

tiffafoo
Copy link

@tiffafoo tiffafoo commented Dec 6, 2021

Summary

Fail status check on cypress failure for all three demo sites and record to cypress dashboard.

Before this PR, cypress tests would run onSuccess, and the only way to tell if something failed was to check the deploy logs. Now there are a couple new ways, including comments and the cypress dashboard (in the deploy logs, it also shows a link of the recorded run). You are also able to access video recording of runs which is helpful to debug failed runs.

Keep in mind we are in the free tier here, and we'll have to see if we need to upgrade
CleanShot 2021-12-09 at 12 22 02@2x

Test plan

See cypress comments below and deploy logs

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

#839

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Dec 6, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 2452bbc

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b1cb0df4b886000821caf3

😎 Browse the preview: https://deploy-preview-899--netlify-plugin-nextjs-static-root-demo.netlify.app

@netlify
Copy link

netlify bot commented Dec 6, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 2452bbc

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b1cb0d63f3b80008ca2307

😎 Browse the preview: https://deploy-preview-899--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Dec 6, 2021
@tiffafoo tiffafoo marked this pull request as ready for review December 6, 2021 12:46
@tiffafoo tiffafoo marked this pull request as draft December 6, 2021 12:46
@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 2452bbc

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b1cb0d2fd4d600089a64f0

😎 Browse the preview: https://deploy-preview-899--netlify-plugin-nextjs-demo.netlify.app

@cypress
Copy link

cypress bot commented Dec 9, 2021



Test summary

16 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 2452bbc
Started Dec 9, 2021 9:26 AM
Ended Dec 9, 2021 9:28 AM
Duration 02:20 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 9, 2021



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 2452bbc
Started Dec 9, 2021 9:26 AM
Ended Dec 9, 2021 9:27 AM
Duration 01:09 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 9, 2021



Test summary

6 1 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Failed
Commit 2452bbc
Started Dec 9, 2021 9:25 AM
Ended Dec 9, 2021 9:27 AM
Duration 01:22 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


Failures

../../cypress/integration/static-root/i18n.spec.ts Failed
1 Localization > should use Accept-Language to choose a locale

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tiffafoo tiffafoo marked this pull request as ready for review December 9, 2021 09:18
@tiffafoo tiffafoo requested a review from ascorbic December 9, 2021 09:25
@tiffafoo tiffafoo changed the title chore: add to cypress dashboard default chore: add to cypress dashboard for all demo sites Dec 9, 2021
@ascorbic
Copy link
Contributor

ascorbic commented Dec 9, 2021

LOVE THIS!!

@kodiakhq kodiakhq bot merged commit 84334eb into main Dec 9, 2021
@kodiakhq kodiakhq bot deleted the tln/cypress-status branch December 9, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants