chore: 🚙 type some helper files and constants #860
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,22 @@ | ||
| import { posix } from 'path' | ||
|
|
||
| export const restoreCache = async ({ cache, publish }) => { | ||
| const cacheDir = posix.join(publish, 'cache') | ||
|
|
||
| if (await cache.restore(cacheDir)) { | ||
| console.log('Next.js cache restored.') | ||
| } else { | ||
| console.log('No Next.js cache to restore.') | ||
| } | ||
| } | ||
|
|
||
| export const saveCache = async ({ cache, publish }) => { | ||
| const cacheDir = posix.join(publish, 'cache') | ||
|
|
||
| const buildManifest = posix.join(publish, 'build-manifest.json') | ||
| if (await cache.save(cacheDir, { digests: [buildManifest] })) { | ||
| console.log('Next.js cache saved.') | ||
| } else { | ||
| console.log('No Next.js cache to save.') | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| /* eslint-disable eslint-comments/disable-enable-pair, @typescript-eslint/no-empty-interface, no-use-before-define */ | ||
|
There was a problem hiding this comment. Ah, nice. Maybe we should contribute this upstream! There was a problem hiding this comment. Good call! Although I'm sure the definition file is missing some types since it was just auto-generated based on the demo's |
||
| /** | ||
| * This was generated using @see {@link https://quicktype.io/}, and using the | ||
| * demo's {@code demos/default/.next/required-server-files.json} file. I was | ||
| * unable to find any types for this file so instead this was manually generated | ||
| */ | ||
|
|
||
| export interface RequiredServerFiles { | ||
| version?: number; | ||
| config?: Config; | ||
| appDir?: string; | ||
| files?: string[]; | ||
| ignore?: string[]; | ||
| } | ||
|
|
||
| export interface Env { | ||
| } | ||
|
|
||
| export interface Config { | ||
| env?: Env; | ||
| webpack?: null; | ||
| webpackDevMiddleware?: null; | ||
|
There was a problem hiding this comment. ^ these will have to be manually updated, since it's clearly wrong |
||
| eslint?: Eslint; | ||
| typescript?: Typescript; | ||
| distDir?: string; | ||
| cleanDistDir?: boolean; | ||
| assetPrefix?: string; | ||
| configOrigin?: string; | ||
| useFileSystemPublicRoutes?: boolean; | ||
| generateEtags?: boolean; | ||
| pageExtensions?: string[]; | ||
| target?: string; | ||
| poweredByHeader?: boolean; | ||
| compress?: boolean; | ||
| analyticsId?: string; | ||
| images?: Images; | ||
| devIndicators?: DevIndicators; | ||
| onDemandEntries?: OnDemandEntries; | ||
| amp?: Amp; | ||
| basePath?: string; | ||
| sassOptions?: Env; | ||
| trailingSlash?: boolean; | ||
| i18n?: I18N; | ||
| productionBrowserSourceMaps?: boolean; | ||
| optimizeFonts?: boolean; | ||
| excludeDefaultMomentLocales?: boolean; | ||
| serverRuntimeConfig?: Env; | ||
| publicRuntimeConfig?: Env; | ||
| reactStrictMode?: boolean; | ||
| httpAgentOptions?: HTTPAgentOptions; | ||
| outputFileTracing?: boolean; | ||
| staticPageGenerationTimeout?: number; | ||
| swcMinify?: boolean; | ||
| experimental?: Experimental; | ||
| future?: Future; | ||
| configFileName?: string; | ||
| } | ||
|
|
||
| export interface Amp { | ||
| canonicalBase?: string; | ||
| } | ||
|
|
||
| export interface DevIndicators { | ||
| buildActivity?: boolean; | ||
| buildActivityPosition?: string; | ||
| } | ||
|
|
||
| export interface Eslint { | ||
| ignoreDuringBuilds?: boolean; | ||
| } | ||
|
|
||
| export interface Experimental { | ||
| cpus?: number; | ||
| sharedPool?: boolean; | ||
| plugins?: boolean; | ||
| profiling?: boolean; | ||
| isrFlushToDisk?: boolean; | ||
| workerThreads?: boolean; | ||
| pageEnv?: boolean; | ||
| optimizeImages?: boolean; | ||
| optimizeCss?: boolean; | ||
| scrollRestoration?: boolean; | ||
| externalDir?: boolean; | ||
| reactRoot?: boolean; | ||
| disableOptimizedLoading?: boolean; | ||
| gzipSize?: boolean; | ||
| craCompat?: boolean; | ||
| esmExternals?: boolean; | ||
| isrMemoryCacheSize?: number; | ||
| concurrentFeatures?: boolean; | ||
| serverComponents?: boolean; | ||
| fullySpecified?: boolean; | ||
| outputFileTracingRoot?: string; | ||
| outputStandalone?: boolean; | ||
| } | ||
|
|
||
| export interface Future { | ||
| strictPostcssConfiguration?: boolean; | ||
| } | ||
|
|
||
| export interface HTTPAgentOptions { | ||
| keepAlive?: boolean; | ||
| } | ||
|
|
||
| export interface I18N { | ||
| defaultLocale?: string; | ||
| locales?: string[]; | ||
| } | ||
|
|
||
| export interface Images { | ||
| deviceSizes?: number[]; | ||
| imageSizes?: number[]; | ||
| path?: string; | ||
| loader?: string; | ||
| domains?: any[]; | ||
| disableStaticImages?: boolean; | ||
| minimumCacheTTL?: number; | ||
| formats?: string[]; | ||
| } | ||
|
|
||
| export interface OnDemandEntries { | ||
| maxInactiveAge?: number; | ||
| pagesBufferLength?: number; | ||
| } | ||
|
|
||
| export interface Typescript { | ||
| ignoreBuildErrors?: boolean; | ||
| tsconfigPath?: string; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I htink it's a good idea if we ensure that all exported functions have typed args and return values, even if they're just defined inline.