feat: replace node-fetch with builtin #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
| await new Promise((resolve, reject) => { | ||
| const req = httpx.get(url, { timeout: 10000 }, (response) => { | ||
| if (response.statusCode < 200 || response.statusCode > 299) { | ||
| reject(new Error(`Failed to download ${url}: ${response.statusCode} ${response.statusMessage || ''}`)) |
ascorbic
force-pushed
the
mk/remove-node-fetch
branch
from
21d2289 to
ec752f4
Compare
eduardoboucas
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the runtime requirement for node-fetch with a helper that uses Node builtins
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal