fix: correct redirect priority and correctly handle ISR pages assets #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
force-pushed
the
mk/redirect-sorting
branch
from
c7bf60a to
8361468
Compare
ascorbic
force-pushed
the
mk/redirect-sorting
branch
from
8bf0400 to
739e513
Compare
ascorbic
force-pushed
the
mk/redirect-sorting
branch
from
39f383d to
287cb1f
Compare
ascorbic
changed the title
ascorbic
force-pushed
the
mk/redirect-sorting
branch
from
5f428f3 to
0521168
Compare
ascorbic
force-pushed
the
mk/redirect-sorting
branch
from
39ebdf5 to
02d0834
Compare
ascorbic
commented
Nov 23, 2021
| @@ -4,29 +4,18 @@ const Header = dynamic(() => import(/* webpackChunkName: 'header' */ '../compone | |||
| import { useRouter } from 'next/router' | |||
There was a problem hiding this comment.
These are just some updates to the demo index page, as it used deprecated syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the ordering of rewrites, and adds one to ensure api routes aren't served by ODBs. Also ensures that pre-rendered ISR pages aren't served from the CDN, as they need to be handled by the function.
Test plan
x-render-modeisssrand thedateheader is now. (Don't expect the render time in the page to update)Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #765
🧪 Once merged, make sure to update the version if needed and that it was published correctly.