Skip to content

feat: move static pages by default #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2021
Merged

feat: move static pages by default #816

merged 2 commits into from
Nov 19, 2021

Conversation

ascorbic
Copy link
Contributor

Summary

This PR changes the EXPERIMENTAL_MOVE_STATIC_FILES mode to be the default, so any statically-rendered pages are served from the CDN rather than the origin, unless they match middleware. It adds a new env var SERVE_STATIC_FILES_FROM_ORIGIN to disable the mode.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

image

Release-As: 4.0.0-beta.8
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 19, 2021
@ascorbic ascorbic self-assigned this Nov 19, 2021
@ascorbic ascorbic requested a review from a team November 19, 2021 14:31
@ehmicky ehmicky self-requested a review November 19, 2021 15:16
Copy link

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@kodiakhq kodiakhq bot merged commit 12ce69e into main Nov 19, 2021
@kodiakhq kodiakhq bot deleted the mk/static-pages-flag branch November 19, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants