fix: correctly exclude files #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
changed the title
ascorbic
force-pushed
the
fix/exclude-paths
branch
3 times, most recently
from
8e9f082 to
834f73c
Compare
ascorbic
force-pushed
the
fix/exclude-paths
branch
from
834f73c to
55ad53a
Compare
ascorbic
commented
Oct 19, 2021
| '!node_modules/sharp/**/*', | ||
| ] | ||
| expect(netlifyConfig.functions[HANDLER_FUNCTION_NAME].included_files).toEqual(includes) | ||
| expect(netlifyConfig.functions[ODB_FUNCTION_NAME].included_files).toEqual(includes) | ||
| // Relative paths in Windows are different |
There was a problem hiding this comment.
It was not worth the effort to make the snapshots match on Windows. I tried. I gave up. I'm sorry.
ascorbic
force-pushed
the
fix/exclude-paths
branch
from
03a0b29 to
a2a1e58
Compare
eduardoboucas
approved these changes
Oct 19, 2021
ascorbic
force-pushed
the
fix/exclude-paths
branch
from
34bf0cc to
fb1b07e
Compare
Release-as: 4.0.0-beta.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluded files need to be relative to the base dir, so node modules need to be resolved. Meanwhile, some other files were being excluded that are sometimes needed.