Skip to content

chore(deps): update dependency netlify-cli to ^5.4.3 #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 2, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
netlify-cli ^5.4.1 -> ^5.4.3 age adoption passing confidence

Release Notes

netlify/cli

v5.4.3

Compare Source

v5.4.2

Compare Source


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 2, 2021
@renovate renovate bot force-pushed the renovate/netlify-cli-5.x branch 2 times, most recently from e288ce8 to 65a74fa Compare August 2, 2021 14:01
@renovate renovate bot changed the title chore(deps): update dependency netlify-cli to ^5.4.2 chore(deps): update dependency netlify-cli to ^5.4.3 Aug 2, 2021
@renovate renovate bot force-pushed the renovate/netlify-cli-5.x branch from 65a74fa to 341a2b3 Compare August 2, 2021 14:57
@renovate renovate bot merged commit 50e63bc into main Aug 2, 2021
@renovate renovate bot deleted the renovate/netlify-cli-5.x branch August 2, 2021 15:22
serhalp added a commit that referenced this pull request Jun 13, 2024
* chore(e2e): fix e2e result deduping for [email protected]

Example broken run: https://github.com/netlify/next-runtime-minimal/actions/runs/9410953045.

* chore(e2e): fix summary counts when deduping occurs

We were updating summary tallies as side effects of building up the report, but when I introduced
deduping of test suite retries, this led to a discrepancy between the results in the report and the
summary counts.

I could have fixed this by subtracting the right counts from the running tallies when deduping, but
it seemed cleaner to just refactor this to summary counts computed purely from the final results.

As a bonus, this makes it a lot more obvious that the skipped count makes no sense. I translated the
logic as is, but I'll try to fix this in the next commit.

* chore(e2e): more explicitly output skip counts

It was really misleading and error prone.

This also removes the total, since it wasn't necessary and it was also misleading. We were
calculating it as `passed + failed + individually skipped tests` and then only using it in one
place, which subtracted the individually skipped tests back out.

This also updates the local dev fixtures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant