feat: add support for using image config from next.config.js #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we require users to set an env var to specify allowed domains for images. This is because the next config is not available inside the function at runtime. This is not ideal from a DX perspective, but is particularly bad because of the fact that funcitons can only use env vars that have been set in the UI, not in the toml.
This PR instead writes a snapshot of the image config as a JSON file in the image function dir, while can then
require()it. It still supports the env var for compatibility reasons, by merging any domains specified there. However it also emits a warning telling the user to switch to using thenext.config.jsinstead.Fixes #516