fix: handle Storybook and other sites that don't build #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we detect a site as using Next.js and auto-install the plugin then builds will fail with an error message that isn't very intuitive. In a lot of cases these are actual Next.js sites, but the deployed site is building the STorybook rather than the actual site. This is a common enough pattern for it to be worth detecting specifically. This PR detects the
build-storybookcommand and skips the plugin. It also adds an explicit check for the Next build directory after the build, and if it's missing it fails the build with links to docs on configuration or removing the plugin.Fixes #495