Skip to content

Improve npm install fix #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Improve npm install fix #48

merged 1 commit into from
Nov 18, 2020

Conversation

ehmicky
Copy link

@ehmicky ehmicky commented Nov 17, 2020

Discussion at #10

The npm install next-on-netlify can be simplified to npm install next-aws-lambda instead (which should be slightly faster).
@lindsaylevine can you please confirm this still works?

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 17, 2020
@ehmicky ehmicky self-assigned this Nov 17, 2020
Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed !

@lindsaylevine lindsaylevine merged commit 24b42fc into main Nov 18, 2020
@ehmicky ehmicky deleted the bug/function-fix branch November 18, 2020 14:14
serhalp pushed a commit that referenced this pull request Apr 5, 2024
* ci: fix the release-please workflow

* chore: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants