fix: try to resolve next modules via multiple paths #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const loadConfig = require(resolveNextModule( | ||
| ['next/dist/next-server/server/config', 'next/dist/server/config'], | ||
| cwd, | ||
| )).default |
| } | ||
| } | ||
|
|
||
| throw new Error(`Could not resolve Next module. Tried "${modules.join(', ')}"`) | ||
| } |
serhalp
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Create e2e-report.yml * remove cli install * add secret + step for downlaod * remove commented out schedule * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js recently changed its directory structure, which broke our deep imports ( #475 ). This PR adds support to
resolveNextModulefor passing arrays of paths, to allow backward-compatible updates to paths like these. Meanwhile it also adds integration tests againstnext@canaryto make this less likely to happen. We also have plans to add automatic tests against new canary releases.Fixes #475