Make next a peer dependency
#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
ehmicky
force-pushed
the
feat/next-peer-dependency
branch
2 times, most recently
from
546ecf6 to
9d2c594
Compare
Closed
ehmicky
force-pushed
the
feat/next-peer-dependency
branch
from
9d2c594 to
3866870
Compare
This was referenced Nov 17, 2020
lindsaylevine
approved these changes
Nov 17, 2020
helpers/validateNextUsage.js
Outdated
| } | ||
| } | ||
|
|
||
| module.exports = { validateNextUsage } |
There was a problem hiding this comment.
curious why exported as object instead of just module.exports = validateNextUsage
There was a problem hiding this comment.
If this file exports new functions in the future, we don't need to update the files importing validateNextUsage().
I can change it to a default export if you prefer though. Which one do you prefer?
There was a problem hiding this comment.
no preference! just used to the default non-object export consistent throughout NoN but i'm totally cool with being future-proof here, i think it makes sense if you think we might put another func/helper in here. up to you!
There was a problem hiding this comment.
Let's go with consistency and use a default export. Fixed 👍
| @@ -46,6 +46,11 @@ module.exports = { | |||
|
|
|||
| const nextConfigPath = await findUp('next.config.js') | |||
| if (nextConfigPath !== undefined) { | |||
| // We cannot load `next` at the top-level because we validate whether the | |||
| // site is using `next` inside `onPreBuild`. | |||
ehmicky
force-pushed
the
feat/next-peer-dependency
branch
from
3866870 to
4acffcf
Compare
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
* feat: add cache set for route handler * chore: increase timeout as tests are flaky * chore: update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26 and #8
Also part of #25
This makes
nexta peer dependency, which allows users to define which Next.js version they prefer (among the versions we support).It a site is not using
next, an error message is shown.This also changes the version range of
nextfrom^9.5.3to>=9.5.3so that Next.js 10 users can use this, although support is experimental and we will print a warning message (to be done in separate PR).Testing this turns out to be quite complicated. Making
require('next')fail in automated tests is pretty hard to achieve without mockingrequire()which could bring its own sets of problems. Tests neednextas adevDependencyto run properly, sorequire('next')is guaranteed to succeed otherwise, even when the current directory changes (sincerequire()is based on__filenameinstead). So I think we might need to leave out automated testing for this specific validation check (and also for the upcoming Next.js versions checks).