feat: don't upscale images #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
|
npm ERR! @netlify/routing-local-proxy-darwin-x64 not accessible from netlify-cli:@netlify/routing-local-proxy pain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents us from resizing images to larger than the source. Instead we can let next/image do the resizing in the browser. Rather than returning the max size image, we instead redirect to the image that is the correct size. This is to avoid having multiple URLs that all refer to the same image, which the browser will potentially download multiple times.
Demo page. The image is displayed at twice the source size. Open the image in a new tab and you'll see it has redirected to the smaller size