Skip to content

fix(watch): add missing bin property #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021
Merged

fix(watch): add missing bin property #355

merged 1 commit into from
May 27, 2021

Conversation

erezrokah
Copy link

@erezrokah erezrokah commented May 26, 2021

This allows running npx netlify-plugin-nextjs watch to run the plugin in watch mode so it executes next build and netlify-on-netlify build on src files changes.

This used to be supported in netlify-on-netlify.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 26, 2021
@erezrokah erezrokah requested a review from lindsaylevine May 26, 2021 15:43
@@ -43,7 +43,7 @@ const watch = (functionsPath, publishPath) => {
const runBuild = debounceFn(
async () => {
try {
execa.sync('next', ['build'], { stdio: 'inherit' })
execa.sync('next', ['build'], { stdio: 'inherit', preferLocal: true })
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferLocal so it uses the locally installed next version

Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the best!

@erezrokah erezrokah merged commit 5a70c61 into main May 27, 2021
@erezrokah erezrokah deleted the fix/add_bin branch May 27, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants