fix: refactor image function #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
approved these changes
May 17, 2021
There was a problem hiding this comment.
amazing!!!!!!! i think this might also fix #133 which i forgot about until i saw the env var?! just added the label to it - lmk what you think and/or comment on it if you see fit!!!
|
|
||
| let { ext } = type | ||
|
|
||
| // For unsupported formats (gif, svg) we redirect to the original |
| } | ||
|
|
||
| // The format methods are just to set options: they don't | ||
| // make it return that format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the image function. The main fixes are improved error handling and new logic to determine output format. The logic for choosing the output format is as follows:
FORCE_WEBP_OUTPUTis set, then set output format to WebP.Fixes Support for GIF and SVG in next/image #307 and [next_image] Fails to load most of JPG images. (Input buffer contains unsupported image format) #312