test: add handling for skipped tests moved out of e2e/basepath/basepath.test.ts
#2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Jun 16, 2025
| @@ -29,6 +29,8 @@ | |||
| "test/e2e/app-dir/revalidate-dynamic/revalidate-dynamic.test.ts", | |||
| "test/e2e/app-dir/rsc-basic/rsc-basic.test.ts", | |||
| "test/e2e/basepath.test.ts", | |||
| "test/e2e/basepath/basepath.test.ts", | |||
There was a problem hiding this comment.
forgot to add this one here a couple weeks ago for the previous rename
serhalp
commented
Jun 16, 2025
Comment on lines
+224
to
+227
| "tests": [ | ||
| "basePath should not update URL for a 404", | ||
| "basePath should show 404 for page not under the /docs prefix" | ||
| ] |
There was a problem hiding this comment.
there were three tests skipped here previously, but one of these is now passing so I didn't include it
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See vercel/next.js@3f9f403.
Some tests were split out of the test file we were referencing into new test files. This adds handling for the new file name. We must keep the previous config to support running tests against older versions.
See example "unknown failure": https://github.com/opennextjs/opennextjs-netlify/actions/runs/15643078756.
Documentation
N/A
Tests
N/A
Relevant links (GitHub issues, etc.) or a picture of cute animal
N/A