test: print cli output when timing out #2959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
e2e-vercel-timeout-deploy-logs
branch
from
02f8962 to
7a22d98
Compare
This reverts commit 7a22d98.
pieh
changed the title
pieh
commented
Jun 11, 2025
Comment on lines
-171
to
+186
| console.error(err) | ||
| require('console').error(err) |
There was a problem hiding this comment.
not related to main change
this error was not being printed out before - there is some weird console patching going on - so adjusting this to be same as other logs in case those might hide some important detail for us that would help debugging
pieh
force-pushed
the
e2e-vercel-timeout-deploy-logs
branch
from
f68cb4b to
30cc0f2
Compare
serhalp
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To aid with debugging vercel/next tests that are just timing out without any meaningful output this captures the output and will print it out if
destroy()is called before deploy finished to figure out if something is just slow or we are sometimes hanging on something.See example https://github.com/opennextjs/opennextjs-netlify/actions/runs/15591799921/job/43913715730#step:20:82 (from test run on tmp commit that was intentionally timing out)