feat: use ODB (fallback pages + next/image) #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
added
the
type: feature
lindsaylevine
force-pushed
the
apr-13-odb-dpr
branch
2 times, most recently
from
2bdbd5b to
052aaf7
Compare
|
need to investigate this: #155 (comment) |
lindsaylevine
force-pushed
the
apr-13-odb-dpr
branch
2 times, most recently
from
8b1b533 to
fc1c2af
Compare
is this a blocker to this being merged? |
|
I hope my comment is not a blocker @lindsaylevine, honestly if gifs can make it that's enough to me 😄 The other image might be a very specific issue on my end due to maybe the use of transparent backgrounds |
ascorbic
approved these changes
May 13, 2021
lindsaylevine
force-pushed
the
apr-13-odb-dpr
branch
2 times, most recently
from
52a546f to
e565862
Compare
lindsaylevine
force-pushed
the
apr-13-odb-dpr
branch
from
e565862 to
396e2d0
Compare
|
@MaximeHeckel this PR does not include gif support. i've learned it's a lot more complicated/effort than i imagined. i'll open a new issue for you on the repo. i'll also open an issue about the lambda limit as i ran into it myself! ❤️ |
|
That's totally fine, not a problem at all I'll handle gifs separately for now! Thank you for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Addresses #151
this was previously published as a tagged release to npm but now is safe for main!