feat: support 'use cache' #2862
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
michalpiechowiak/frb-1405-next15-use-cache-not-persisted
branch
3 times, most recently
from
de692a4 to
3b2a0f2
Compare
pieh
force-pushed
the
michalpiechowiak/frb-1405-next15-use-cache-not-persisted
branch
from
7fa0925 to
81fd1b4
Compare
pieh
force-pushed
the
michalpiechowiak/frb-1405-next15-use-cache-not-persisted
branch
2 times, most recently
from
4cd7931 to
d51d811
Compare
pieh
force-pushed
the
michalpiechowiak/frb-1405-next15-use-cache-not-persisted
branch
3 times, most recently
from
7888b9a to
04d4a9b
Compare
pieh
force-pushed
the
michalpiechowiak/frb-1405-next15-use-cache-not-persisted
branch
2 times, most recently
from
6b28b3b to
a929442
Compare
pieh
added
the
test all versions
pieh
force-pushed
the
michalpiechowiak/frb-1405-next15-use-cache-not-persisted
branch
from
a929442 to
1b4c220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is work in progress to support upcoming
'use cache'directiveNotes:
The primary need for custom Netlify cache handler implementation (the new one, that is used by
'use cache'directive) is that default implementation is in-memory only. While it seems like at leastdefaulthandler foruse cachedoesn't need entries to be actually persisted - it still need to support tags (seecacheTag) properly and in serverless environment it means that we can't use in-memory only tag manifest like the default implementation does and will need to check with some persisted source of truth.Review notes:
This PR contains also changes from following refactor PRs that it depends on.
To check just "use cache" specific changes without polluting diff with refactors use this compare view
Documentation
Tests
Primarily integration tests are being added for various
use cachescenarios:use cacheis used on (data fetching function, non-page react component, page react component, whole page module)And test check behavior when executing against same serverless function instance, different serverless function instances (default cache is in-memory only, so to test behaviors it forces use of integration tests as you can't ensure hitting same or different serverless function in e2e), checking behaviors after tag invalidation (also depending on wether same serverless instance is used or not and that it should work the same in both cases because tags are shared, while cache entries themselves are not) and finally checking that expiry behavior works.
Relevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1405/[next15]-use-cache-not-persisted