test: wait for background work to finish in integration tests #2851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
commented
Apr 16, 2025
| })) as LambdaResponse | ||
|
|
||
| await invocationPromise |
There was a problem hiding this comment.
possibly instead of awaiting here we should return this promise, but before https://github.com/netlify/serverless-functions-api/pull/358 landed we were basically waiting for stream to close here and we were blocking stream closing to ensure background work
making change to return this promise as part of results instead of awaiting would like require test adjustments, so I think it's better to restore previous behavior
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
approved these changes
Apr 16, 2025
pieh
deleted the
michalpiechowiak/frb-1714-flaky-test-purge-api-is-not-used-when-unstable_cache-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
waitUntilwas shipped, our integration test'sinvokeFunctionwas not awaiting background work which resulted in some flakiness - specifically visible on Windows runners. This restore previous behaviorRelevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1714/flaky-test-purge-api-is-not-used-when-unstable-cache-cache-entry-gets