Skip to content

Functions UI build settings #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Functions UI build settings #28

merged 1 commit into from
Nov 13, 2020

Conversation

ehmicky
Copy link

@ehmicky ehmicky commented Nov 13, 2020

Fixes #11.

The following line:

https://github.com/netlify/netlify-plugin-nextjs/blob/7b9a2430f46da57a38c5c85d611b2fc7df6bd777/index.js#L59

Is checking the build.functions configuration property in netlify.toml. However, constants.FUNCTIONS_SRC should be used instead, since it takes more cases into account, such as when users are creating functions directory during build.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Nov 13, 2020
@ehmicky ehmicky self-assigned this Nov 13, 2020
@ehmicky ehmicky force-pushed the bug/fix-functions-src branch from 973f7af to 884efbd Compare November 13, 2020 17:04
@ehmicky ehmicky merged commit 08d39e2 into main Nov 13, 2020
@ehmicky ehmicky deleted the bug/fix-functions-src branch November 13, 2020 18:36
ascorbic added a commit that referenced this pull request Oct 4, 2021
serhalp pushed a commit that referenced this pull request Apr 5, 2024
* feat: add integration tests

* chore: test

* chore: update

* chore:  update

* chore: update

* chore: fix the headers test

* chore: cleanup

* chore: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions UI build settings
2 participants