Skip to content

ci: increase number of shards when running Next.js repo e2e tests #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,16 @@ jobs:
run: |
if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
VERSION_SELECTORS=[${{ github.event.inputs.versions }}]
echo "group=[1, 2, 3, 4]" >> $GITHUB_OUTPUT
echo "total=4" >> $GITHUB_OUTPUT
echo "group=[1, 2, 3, 4, 5, 6]" >> $GITHUB_OUTPUT
echo "total=6" >> $GITHUB_OUTPUT
elif [ "${{ github.event_name }}" == "pull_request" ]; then
VERSION_SELECTORS=[\"latest\"]
echo "group=[1, 2, 3, 4]" >> $GITHUB_OUTPUT
echo "total=4" >> $GITHUB_OUTPUT
echo "group=[1, 2, 3, 4, 5, 6]" >> $GITHUB_OUTPUT
echo "total=6" >> $GITHUB_OUTPUT
else
VERSION_SELECTORS=[\"latest\",\"canary\",\"14.2.15\",\"13.5.1\"]
echo "group=[1, 2, 3, 4]" >> $GITHUB_OUTPUT
echo "total=4" >> $GITHUB_OUTPUT
VERSION_SELECTORS=[\"latest\",\"canary\"]
echo "group=[1, 2, 3, 4, 5, 6]" >> $GITHUB_OUTPUT
echo "total=6" >> $GITHUB_OUTPUT
fi

VERSION_SPEC="["
Expand Down
4 changes: 4 additions & 0 deletions tests/netlify-deploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ export class NextDeployInstance extends NextInstance {
command = "npm run build"
publish = ".next"

[build.environment]
# this allows to use "CanaryOnly" features with next@latest
NEXT_PRIVATE_TEST_MODE = "e2e"

[[plugins]]
package = "${runtimePackageName}"
`
Expand Down
Loading