test: update test setup for stable after() #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
pieh
force-pushed
the
tests/update-after-after-got-stable
branch
from
a0ec10c to
9c0bdfc
Compare
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Dec 11, 2024
Comment on lines
+31
to
+33
| const response = await page.goto(`${after.url}/after/trigger`) | ||
|
|
||
| expect(response?.status(), 'Trigger should return 200').toBe(200) |
There was a problem hiding this comment.
In main this results in 50x status (due to no longer existing export) - the test failed which is good, but assertion errors didn't show much details other than things not working
This added assertion is just to have more context about potential future failures
pieh
commented
Dec 11, 2024
| @@ -85,7 +85,7 @@ export async function setNextVersionInFixture( | |||
| if ( | |||
| operation === 'update' && | |||
| versionConstraint && | |||
| !satisfies(checkVersion, versionConstraint) && | |||
| !satisfies(checkVersion, versionConstraint, { includePrerelease: true }) && | |||
There was a problem hiding this comment.
not needed for this PR, but I noticed that after fixture building was skipped in canary test run which should not happen (we don't have integration test using that fixture, so it wasn't impacting test results - this is just fixing this for the future)
mrstork
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our tests failed last run with underlying reason being:
unstable_afterimport is no longer available, so this updates test setup to use stableafter(and bumps version constraint)Documentation
Tests
Existing test updated
Relevant links (GitHub issues, etc.) or a picture of cute animal