Skip to content

test: adjust setup for next@canary #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

test: adjust setup for next@canary #2553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd52e17
test: make global.__import_unsupported configurable
pieh Jul 23, 2024
3ca2c6f
Merge branch 'main' into chore/reset-globalThis-between-tests
pieh Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/utils/fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,20 @@ async function installDependencies(cwd: string) {
export const getFixtureSourceDirectory = (fixture: string) =>
fileURLToPath(new URL(`../fixtures/${fixture}`, import.meta.url))

// https://github.com/vercel/next.js/pull/67539 added more imports to "globals" modules which does have a side effect at import time
// that defines NOT configurable global property ( https://github.com/vercel/next.js/blob/ba3959bb46f4d0e92403304579b8fb30d3ecc3d1/packages/next/src/server/web/globals.ts#L87-L107 ).
// Running multiple fixtures in the same process then would evaluate copy of that module
// and attempt to redefine that not configurable property which result in an error. We can't delete that property either, so
// this "patch" to Object.defineProperty is making that property configurable when running our tests to avoid that error.
const originalDefineProperty = Object.defineProperty
Object.defineProperty = function (target, property, descriptor) {
if (property === '__import_unsupported' && descriptor?.configurable === false) {
descriptor.configurable = true
}

return originalDefineProperty.call(this, target, property, descriptor)
}

/**
* Copies a fixture to a temp folder on the system and runs the tests inside.
* @param fixture name of the folder inside the fixtures folder
Expand Down
Loading