fix: ISR 404 pages should be cached ephemerally #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MarcL
reviewed
Jul 27, 2023
MarcL
previously approved these changes
Jul 27, 2023
Looks good to me. Thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Next.js it's possible to make an ISR 404 page that revalidates after a period of time.
A 404 page will be served in a number of scenarios, including (but not limited to):
notFound: truefallback: falseid1 and 2 prerendered andfallback: falsenotFound: trueid4 matches a condition that returnsnotFound: trueCurrently, on Netlify, we have inconsistent behavior in these different scenarios. An ISR 404 page will behave like an SSR page in the first 2 scenarios, a static page in the 3rd scenario and an ISR page without a TTL in the last scenario (which is particularly problematic because the
notFoundlogic might change due to some external state changing (e.g. CMS content), but the 404 will remain indefinitely and the route will never be revalidated).These behaviors occur for the following reasons:
fallback: falseare only intended to serve prerendered paths on the route, therefore we currently redirect the entire route to the statically rendered 404 page on the CDN (relying on the CDN to serve the prerendered HTML pages instead of following the redirect)notFound: truewill serve an ISR 404 page, but Next.js does not usestale-while-revalidateheaders in this case, unlike other ISR content, and this prevents us from identifying the response as ISR and extracting the TTLThis PR adds a special case to the TTL logic and assumes that if the route is an ODB route and the status code is 404, then we should only cache the response ephemerally for 60s. It is a stopgap solution designed to limit the impact of point 3 above. With the PR, an ISR 404 will no longer be cached indefinitely, however it will still not respect that actual TTL specified in the
revalidatevalue. This PR does not address points 1 and 2 above, which will be tackled as part of forthcoming changes to the caching implementation.Tests
Tests added