fix: edge cases for custom react module resolution #2188
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const resolvedPath = require.resolve(path, opts) | ||
| mode.set(hook, resolvedPath) | ||
| } catch { | ||
| // ignore |
There was a problem hiding this comment.
Do we need any logging here for our observability or is it safe to just ignore?
There was a problem hiding this comment.
hey @MarcL, this is safe to ignore here because it's not actually an error - we want to delete the hook in this case because it happens when a module isn't found, i.e. an older version of Next
I have updated with a better comment, thanks
…gin-nextjs into rs/react-env-var-fix
| try { | ||
| const resolvedPath = require.resolve(path, opts) | ||
| mode.set(hook, resolvedPath) | ||
| } catch { |
There was a problem hiding this comment.
Consider only deleting the hook when the error thrown is MODULE_NOT_FOUND, otherwise rethrow.
There was a problem hiding this comment.
@nickytonline good plan, have updated in 78fc4d6
orinokai
changed the title
Description
Fix to ensure that the default React module resolution is always used as a fallback when rendering Page Router routes.
This PR also guards against missing module paths in previous versions of Next by try/catching each call to
require.resolve().In addition, this PR fixes a case where paths with query strings caused the route matching to fail.