-
Notifications
You must be signed in to change notification settings - Fork 89
fix: new ISR cache handling to resolve regression in 13.4 #2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e4a11ec
feat: remove server patches
orinokai c867b59
feat: force revalidate and serve initial static ISR content
orinokai 70b73d8
fix: remove unnecessary patching code
orinokai 7b7a2de
fix: only revalidate manually or when ODB revalidates
orinokai ce82ee7
chore: add logging and comments
orinokai 478062b
Merge remote-tracking branch 'origin/main' into rs/isr-fix
nickytonline 14c8a35
test: fixed renders fallback page via ODB on a non-prerendered dynami…
nickytonline 0888742
fix: always revalidate
orinokai e56bbd6
Revert "test: fixed renders fallback page via ODB on a non-prerendere…
nickytonline 9bd37d0
fix: preview cookie matching in request handler
orinokai 6105a4a
Merge branch 'rs/isr-fix' of github.com:netlify/netlify-plugin-nextjs…
orinokai 6565c8a
fix: unnecessary eslint disable
orinokai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, I realized last night that if we only revalidate when an ODB sends that header, then middleware will still be enabled for all other requests (because we're now relying on revalidate mode to disable middleware at the origin). This commit reverts that, so we now revalidate on every request and will have to find a different way to serve the initial static content (but perhaps that's for a separate PR, like you said).