Skip to content

feat: add eslint #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: add eslint #213

wants to merge 1 commit into from

Conversation

lindsaylevine
Copy link

Fixes #210

had to push --no-verify because it was hanging?? not sure why, checked/compared to cli to see if i was missing a dep or something 🤔

@lindsaylevine lindsaylevine added the type: chore work needed to keep the product and development running smoothly label Apr 11, 2021
@lindsaylevine
Copy link
Author

Screen Shot 2021-04-11 at 4 17 26 AM

@lindsaylevine
Copy link
Author

also not sure about the ci failures with run-s 🤡

erezrokah
erezrokah suggested changes Apr 12, 2021
View reviewed changes
Copy link

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to push --no-verify because it was hanging?? not sure why, checked/compared to cli to see if i was missing a dep or something 🤔

I thought it was hanging too, but then it reported over 2000 errors, so maybe it's just slow?

@ehmicky ehmicky requested a review from erezrokah April 26, 2021 15:31
ehmicky
ehmicky suggested changes Apr 26, 2021
View reviewed changes
Copy link

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
Note: CI tests are failing.

ehmicky
ehmicky reviewed Apr 27, 2021
View reviewed changes
@ehmicky ehmicky self-requested a review April 27, 2021 15:07
@lindsaylevine lindsaylevine changed the title chore: add eslint feat: add eslint Apr 28, 2021
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Apr 28, 2021
@lindsaylevine lindsaylevine deleted the ll/eslint branch May 3, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlengstorf jlengstorf Awaiting requested review from jlengstorf

@erezrokah erezrokah Awaiting requested review from erezrokah

@ehmicky ehmicky Awaiting requested review from ehmicky

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint
3 participants
@lindsaylevine @ehmicky @erezrokah