fix: resolve follow-redirects from runtime package #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also in auto-installs
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danez
reviewed
May 17, 2023
| @@ -269,7 +269,7 @@ const traceNextServer = async (publish: string): Promise<string[]> => { | |||
|
|
|||
| export const traceNPMPackage = async (packageName: string, publish: string) => { | |||
| try { | |||
| return await glob(join(dirname(require.resolve(packageName, { paths: [publish] })), '**', '*'), { | |||
| return await glob(join(dirname(require.resolve(packageName, { paths: [__dirname, publish] })), '**', '*'), { | |||
There was a problem hiding this comment.
Are we sure this file is exectued as commonjs and not ESM? because __dirname is only available in commonjs.
There was a problem hiding this comment.
Okay I see that __dirname is also used on other locations in this file.
There was a problem hiding this comment.
It better be, because require.resolve is also absent from ESM.
danez
approved these changes
May 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the Next Runtime is auto-installed, then
follow-redirects(which is a dep ofnext-runtime) won't be resolvable from.next(thepublishdir). This results in an error.To fix this, I'm adding
__dirnameas a second resolution starting point.__dirnamealways points to a file within thenext-runtimepackage, sofollow-redirectsshould be resolvable from there.Previously discussed in https://netlify.slack.com/archives/C02T8ASK2E9/p1684318093610159.
Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal