Skip to content

chore: fix broken image reference from npm package page #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023

Conversation

zachleat
Copy link

@zachleat zachleat commented May 2, 2023

Summary

There is a broken image reference on the top of the npm package README: https://www.npmjs.com/package/@netlify/plugin-nextjs

This fixes that reference by pointing to the fixed image.

Test plan

You can apply the URL manually in devtools on the npm package and it works ok 😅

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

image

Standard checks:


🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@zachleat zachleat requested a review from a team May 2, 2023 21:10
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6451fc2cbb305600085ab6d6
😎 Deploy Preview https://deploy-preview-2082--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6451fc2dbb305600085ab6db
😎 Deploy Preview https://deploy-preview-2082--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6451fc2d3e7f2a0008266462
😎 Deploy Preview https://deploy-preview-2082--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6451fc2dd07ec40008abc8ba
😎 Deploy Preview https://deploy-preview-2082--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6451fc2d3e7f2a000826645d
😎 Deploy Preview https://deploy-preview-2082--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6451fc2da9de71000897c5e9
😎 Deploy Preview https://deploy-preview-2082--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6451fc2d4a27b00008f11458
😎 Deploy Preview https://deploy-preview-2082--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6451fc2d68bfab000841394d
😎 Deploy Preview https://deploy-preview-2082--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 670954d
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6451fc2dd07ec40008abc8bf
😎 Deploy Preview https://deploy-preview-2082--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zachleat! 🚢

@kodiakhq kodiakhq bot merged commit 826d708 into main May 3, 2023
@kodiakhq kodiakhq bot deleted the zl/fix-broken-image-npm branch May 3, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants