fix: do not escape HTML #2007
Merged
fix: do not escape HTML #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarahetter
approved these changes
Mar 22, 2023
nickytonline
approved these changes
Mar 22, 2023
demos/middleware/middleware.ts
Outdated
| @@ -24,7 +24,7 @@ export async function middleware(req: NextRequest) { | |||
| if (pathname.startsWith('/static')) { | |||
| // Unlike NextResponse.next(), this actually sends the request to the origin | |||
| const res = await request.next() | |||
| const message = `This was static but has been transformed in ${req.geo?.city}` | |||
| const message = `This was static & old but has been transformed in ${req.geo?.city}` | |||
There was a problem hiding this comment.
These tests are great. I wonder if it makes sense to test that & would render as the text &? The only use case for that that I can think of is if a code example was in a prop being set. Maybe not worth it. 🤔
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
setPagePropis called it in turn callstransformDatawhich pushes to thedataTransformsarray. Inside the shared edge util it gets accessed:https://github.com/netlify/next-runtime/blob/fb93b5469c570616134d53c10fbed1f7ef78e334/packages/runtime/src/templates/edge-shared/utils.ts#L203-L225
The HTML rewriter is a Deno port of https://developers.cloudflare.com/workers/runtime-apis/html-rewriter/.
By default it escapes HTML, but there is a
htmlsetting: https://developers.cloudflare.com/workers/runtime-apis/html-rewriter/#global-typesSo we can just set this to
trueand fix the issue of incorrectly escaping raw HTML while rewriting the HTML.Test plan
See that the changed e2e test still passes.
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1629
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.