Skip to content

fix: use IMAGE_FUNCTION_NAME constant #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: use IMAGE_FUNCTION_NAME constant #2001

merged 1 commit into from
Mar 21, 2023

Conversation

LekoArts
Copy link

Summary

While looking into https://github.com/netlify/pod-ecosystem-frameworks/issues/376 I searched for the usage of IMAGE_FUNCTION_NAME as the other constants showed all their usages. We had a couple of instances where we used _ipx instead of the constant and thus couldn't find it immediately.

So this is a small QoL PR to use the constant in all relevant places.

@LekoArts LekoArts requested a review from a team March 21, 2023 14:04
@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6419b989c6dfdd0008f6a8ee
😎 Deploy Preview https://deploy-preview-2001--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6419b9897c7343000820a75c
😎 Deploy Preview https://deploy-preview-2001--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6419b9895b17480008015391
😎 Deploy Preview https://deploy-preview-2001--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Mar 21, 2023
@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6419b989f895c4000869701c
😎 Deploy Preview https://deploy-preview-2001--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6419b9892b581400085abf9b
😎 Deploy Preview https://deploy-preview-2001--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6419b989fcce2d0007b3d659
😎 Deploy Preview https://deploy-preview-2001--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6419b98995685000089400de
😎 Deploy Preview https://deploy-preview-2001--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6419b9892d3919000880583f
😎 Deploy Preview https://deploy-preview-2001--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 20d0d39
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6419b98956156400087f511b
😎 Deploy Preview https://deploy-preview-2001--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! :shipit:

@LekoArts LekoArts merged commit 24eaaab into main Mar 21, 2023
@LekoArts LekoArts deleted the use-ipx-constant branch March 21, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants