test: added tests to check that the vary header contains 'RSC' #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nickytonline
force-pushed
the
nickytonline/use-vary-header-for-rsc
branch
2 times, most recently
from
331a956 to
ae79440
Compare
nickytonline
force-pushed
the
nickytonline/use-vary-header-for-rsc
branch
from
513d23e to
660afd5
Compare
nickytonline
force-pushed
the
nickytonline/use-vary-header-for-rsc
branch
from
660afd5 to
958fb89
Compare
nickytonline
force-pushed
the
nickytonline/use-vary-header-for-rsc
branch
from
9073caf to
2620db5
Compare
sarahetter
previously approved these changes
Mar 16, 2023
taty2010
previously approved these changes
Mar 16, 2023
ascorbic
reviewed
Mar 16, 2023
|
|
||
| // Set the 'vary' header to 'RSC' to ensure that we cache correctly for the different | ||
| // possible content-types: application/octet-stream and text/html | ||
| request.headers.set('vary', 'RSC') |
There was a problem hiding this comment.
Shouldn't this be on the Response?
There was a problem hiding this comment.
Yeah, you're right. Not sure why I put it on the request (late night coding 🙃 ), and also not sure why my tests and curls pass. 🤔
There was a problem hiding this comment.
It already worked. The problem isn't it returning the wrong data - that was already fixed. The problem is the browser caching the wrong data. The tests should be checking that the server is returning the Vary header, and you can manually test it in the browser with the instructions in https://github.com/netlify/pod-ecosystem-frameworks/issues/352
There was a problem hiding this comment.
I've added tests to check for the vary header. Oddly enough, it looks like the vary header is working already. I removed my change and just updated tests.
ascorbic
reviewed
Mar 17, 2023
nickytonline
changed the title
github-actions
bot
added
the
type: chore
nickytonline
dismissed stale reviews from sarahetter and taty2010
scope of the PR changed. It's only tests now.
LekoArts
approved these changes
Mar 23, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Revert "test: added tests to check that the vary header contains 'RSC' (#1993)" This reverts commit 124d4ae. * Revert "Revert "test: added tests to check that the vary header contains 'RSC' (#1993)"" This reverts commit 4731be5. * test: skipping vary header test for rsc for now until issue is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where requests coming in to the edge function that were handling React Server Components were always returning the first cached response causing issues with serving the content typetext/htmlorapplication/octet-streamIt looks like the
varyheader is already in the response, so I've added tests to ensure it remains.Closes https://github.com/netlify/pod-ecosystem-frameworks/issues/352
Test plan
There is an end-to-end test in this PR that tests that this works, but you can also curl the deploy preview to see it working.
curl -v https://deploy-preview-1993--netlify-plugin-nextjs-demo.netlify.app/blog/erica/. The content type returned iscontent-type: text/html; charset=utf-8curl -v -H "RSC: 1" https://deploy-preview-1993--netlify-plugin-nextjs-demo.netlify.app/blog/erica/, The content type returned iscontent-type: application/octet-streamRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.