feat: add multiple set-cookie headers in middleware #1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MarcL
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Thanks for the quick debugging on this, @sarahetter! 🎉
(but added the comment on the code as I've just thought about it!)
MarcL
reviewed
Mar 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where Deno Headers.set overwrites the previously set header, instead of adding a new
set-cookieheader. This means that we only ever had oneset-cookieheader, which was always the most recently added cookie.You are supposed to set multiple
set-cookieheaders, one per cookie (not a string of multiple cookies in one header). Deno's PR to add the ability to add multipleset-cookieheaders uses theappendmethod. See example in their test files for the PR.I removed @taty2010 's work to do with adding originCookies , as it turned out not to be required - the origin set-cookie headers were already present in the
responseobject, but because we were doingresponse.headers.set(key, value)with a middlewareset-cookieheader, it removed all of the origin set-cookie headers and replaced them with the last-executed middlewareset-cookieheader. This PR is tested by the original tests in Taty's original PR.This PR also solves an issue where you were only able to set one cookie in your middleware file, which we thought was a feature but was actually a bug 🐛 😅
Test plan
response.cookies.set('something', 'myvalue)to a middleware.ts fileset-cookieheaders (multiple from middleware, one from origin) are present on the response.Related: https://github.com/netlify/pillar-support/issues/306
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.