feat: make edge image opt-in instead of opt-out #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarahetter
changed the title
github-actions
bot
added
the
type: feature
MarcL
reviewed
Feb 23, 2023
nickytonline
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Tested things out and it works great:
- The default demo site loads all the images as expected.
- with opt-in set to true we have ipx for edge
5. Edge Functions bundling
────────────────────────────────────────────────────────────────
Packaging Edge Functions from .netlify/edge-functions directory:
- ipx
- next_app_app_edge_page
- next_pages_api_og
- next_pages_edge__id_
- rsc-data
(Edge Functions bundling completed in 2.3s)
- and without edge for ipx when opt-in is not enabled (default)
5. Edge Functions bundling
────────────────────────────────────────────────────────────────
Packaging Edge Functions from .netlify/edge-functions directory:
- next_app_app_edge_page
- next_pages_api_og
- next_pages_edge__id_
- rsc-data
(Edge Functions bundling completed in 1.2s)
stephmarie17
approved these changes
Feb 28, 2023
Co-authored-by: Stephanie <[email protected]>
Co-authored-by: Stephanie <[email protected]>
Co-authored-by: Stephanie <[email protected]>
Co-authored-by: Stephanie <[email protected]>
Co-authored-by: Stephanie <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes edge ipx opt-in instead of opt-out. Does not deprecate any of the old IPX related env vars, such as
NEXT_DISABLE_EDGE_IMAGESorDISABLE_IPXTo use edge images, you must set
NEXT_FORCE_EDGE_IMAGES=true. IPX is created as a regular Netlify Function by default, and will not be run on the edge.@stephmarie17 can you please check my updates to the README file?
Test plan
NEXT_FORCE_EDGE_IMAGES=true ntl deploy --buildon the default demo, go to logs and check that thenext/image handleredge function existsntl deploy --buildon the default demo, go to logs, and check that thenext/image handleredge function does not exist/imageroute, make sure images are showing up - (this is not running on the edge anymore, but images should still appear)Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Closes https://github.com/netlify/pod-ecosystem-frameworks/issues/342
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.