Skip to content

fix: change deprecated set-output github actions #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

MarcL
Copy link
Contributor

@MarcL MarcL commented Feb 13, 2023

Summary

GitHub is deprecating the set-output workflow command in actions after 31st May 2023.

This PR changes the GitHub workflow to use the new format.

Test plan

  1. Check that the PR actions work as expected with a pre-release

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

image

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

@MarcL MarcL requested a review from a team February 13, 2023 17:17
@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/63ea795732915400083ba744
😎 Deploy Preview https://deploy-preview-1924--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63ea7957cfc74600081baf14
😎 Deploy Preview https://deploy-preview-1924--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/63ea7957b5d19800086d56bc
😎 Deploy Preview https://deploy-preview-1924--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Feb 13, 2023
@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63ea7957cea08400087ac8d5
😎 Deploy Preview https://deploy-preview-1924--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/63ea79579e890c000875d691
😎 Deploy Preview https://deploy-preview-1924--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63ea7957051ca00008f6e72a
😎 Deploy Preview https://deploy-preview-1924--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63ea7957560599000859594f
😎 Deploy Preview https://deploy-preview-1924--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63ea795739902e00085ca417
😎 Deploy Preview https://deploy-preview-1924--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit b1c1c18
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/63ea79579e890c000875d68f
😎 Deploy Preview https://deploy-preview-1924--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and approve as the check failures are not related to this change. :shipit:

@MarcL MarcL merged commit 2e0a358 into main Feb 13, 2023
@MarcL MarcL deleted the marcl/fix-github-actions branch February 13, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants