Skip to content

feat: use edge function layer for ipx #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2023
Merged

feat: use edge function layer for ipx #1880

merged 6 commits into from
Apr 5, 2023

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jan 11, 2023

Summary

Switches the IPX content negotiation edge handler to use edge function layers instead of defining the function inline. DO NOT MERGE UNTIL EDGE LAYERS ARE GA

Test plan

  1. Visit /image in the default demo

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

happy capy
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/328

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/642dc0c73560bd0008f6d5dc
😎 Deploy Preview https://deploy-preview-1880--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/642dc0c74b6c200008eef0dd
😎 Deploy Preview https://deploy-preview-1880--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/642dc0c78248d7000882efe2
😎 Deploy Preview https://deploy-preview-1880--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 11, 2023
@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/642dc0c7b6d6b50008c1b904
😎 Deploy Preview https://deploy-preview-1880--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/642dc0c7fb7e080008cd49a9
😎 Deploy Preview https://deploy-preview-1880--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/642dc0c71bff130008ceceea
😎 Deploy Preview https://deploy-preview-1880--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/642dc0c7a9fae10007776fc7
😎 Deploy Preview https://deploy-preview-1880--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/642dc0c7c052f6000792aa4f
😎 Deploy Preview https://deploy-preview-1880--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 11a4b66
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63db9b2c5fded70009a3587b
😎 Deploy Preview https://deploy-preview-1880--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic self-assigned this Jan 12, 2023
@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit d5ec8c9
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/642dc0c73560bd0008f6d5e1
😎 Deploy Preview https://deploy-preview-1880--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nickytonline nickytonline marked this pull request as ready for review April 3, 2023 19:38
@nickytonline nickytonline requested a review from a team April 3, 2023 19:38
@nickytonline nickytonline merged commit 56c7828 into main Apr 5, 2023
@nickytonline nickytonline deleted the mk/ipx-layer branch April 5, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants