test: re-enable unit tests #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: chore
ascorbic
commented
Dec 21, 2022
| @@ -3,10 +3,11 @@ | |||
| exports[`function helpers config dependency tracing extracts a list of all dependencies 1`] = ` | |||
| Array [ | |||
There was a problem hiding this comment.
According to git bisect, these started failing in 8717730 which indicates it's just down to an update in the version of Next.js
ascorbic
commented
Dec 21, 2022
| "status": 200, | ||
| "to": "/.netlify/builders/___netlify-odb-handler", | ||
| "status": 404, | ||
| "to": "/server/pages/en/404.html", |
ascorbic
commented
Dec 21, 2022
| @@ -335,22 +344,6 @@ Array [ | |||
| "pages/en/getStaticProps/static.json", | |||
| "_next/data/build-id/en/getStaticProps/static.json", | |||
| ], | |||
| Array [ | |||
There was a problem hiding this comment.
Introduced in a5b8047 (app dir)
There was a problem hiding this comment.
OK, this is because we no longer move ISR pages, because they're needed for the first request. https://github.com/netlify/next-runtime/blob/main/packages/runtime/src/helpers/files.ts#L158
ericapisani
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we added the Next e2e tests, a mistake in the jest config meant that the
index.jstest no longer matched, and so the tests weren't being run. This PR re-enables them. However the snapshots have changed since then, which wasn't caught because the tests weren't being run.I have run
git bisectto find the commits that broke each of the tests, and have commented with details. They all seem to be fine.