fix: serve static files from basePath #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-export-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo canceled.
|
✅ Deploy Preview for next-plugin-edge-middleware canceled.
|
✅ Deploy Preview for next-plugin-canary canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-demo canceled.
|
✅ Deploy Preview for nextjs-plugin-custom-routes-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.
|
✅ Deploy Preview for next-i18next-demo canceled.
|
ascorbic
commented
Dec 21, 2022
test/e2e/modified-tests/i18n-ignore-rewrite-source-locale/rewrites-with-basepath.test.ts
Outdated
Show resolved
Hide resolved
|
Re-running the e2e tests now that the incident is mitigated |
ascorbic
force-pushed
the
mk/static-basepath
branch
from
db07fb2 to
5d5df9f
Compare
|
Love it!! Thank you so much! |
nickytonline
approved these changes
Dec 21, 2022
|
Looks like there are some E2E tests failing. |
|
This is "should have correct route params for chained rewrite from middleware to config rewrite", which @orinokai thought was related to the Next update, but seems to be failing in main too. As it's unrelated I don't think it's a blocker, and I'll investigate it properly tomorrow |
ericapisani
approved these changes
Dec 21, 2022
gfox-dev
approved these changes
Dec 22, 2022
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a site defined a
basePath, static files were being incorrectly served from the root rather than the basePath.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1849
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.