chore: fix eslint config #1818
Merged
chore: fix eslint config #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo canceled.
|
✅ Deploy Preview for next-plugin-canary canceled.
|
github-actions
bot
added
the
type: chore
✅ Deploy Preview for netlify-plugin-nextjs-export-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-demo canceled.
|
✅ Deploy Preview for next-plugin-edge-middleware canceled.
|
✅ Deploy Preview for nextjs-plugin-custom-routes-demo canceled.
|
✅ Deploy Preview for next-i18next-demo canceled.
|
ericapisani
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disables
n/no-missing-import. This rule isn't needed for TypeScript, and was causing false test failures.Test plan
npm run formatlocally and see that it passes.Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.