You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a locale such as de-DE to next.config.ts, we were giving an Invalid URL error as it our cdn lowercases paths. By adding a rewrite when these locale redirects are happening, we are able to point at the correct site.
Test plan
Visit the middleware Deploy Preview /de-DE/static route
Observe that the page shows up without an Invalid URL error
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
@ascorbic / @nickytonline Just looked with Nick - PR looks fine, just a few of the deploy previews are failing because it's unable to find the new @netlify/edge-functions (and some are able to find it properly 😕 )
I'm away for December, can one of you take care of this while I'm gone?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When adding a locale such as
de-DE
to next.config.ts, we were giving an Invalid URL error as it our cdn lowercases paths. By adding a rewrite when these locale redirects are happening, we are able to point at the correct site.Test plan
/de-DE/static
routeInvalid URL
errorRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/300

Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.