Skip to content

fix: exclude sourcemaps from bundle #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix: exclude sourcemaps from bundle #1772

merged 1 commit into from
Nov 14, 2022

Conversation

ascorbic
Copy link
Contributor

Summary

Exclude sourcemaps from function bundles. These can be massive.

Test plan

  1. Visit the default deploy preview and ensure SSR pages and API routes load

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

image

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic requested a review from a team November 14, 2022 10:47
@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/63721cc4629d8900099190fe
😎 Deploy Preview https://deploy-preview-1772--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63721cc485fa0d0008a4ac21
😎 Deploy Preview https://deploy-preview-1772--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/63721cc491962c000868f629
😎 Deploy Preview https://deploy-preview-1772--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63721cc4a91a51000863200e
😎 Deploy Preview https://deploy-preview-1772--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic self-assigned this Nov 14, 2022
@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/63721cc4cefa8d000ae6f2a4
😎 Deploy Preview https://deploy-preview-1772--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 14, 2022
@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/63721cc4a91a510008632013
😎 Deploy Preview https://deploy-preview-1772--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63721cc490d38400088bfa84
😎 Deploy Preview https://deploy-preview-1772--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63722ff7a988d636307c7b44
😎 Deploy Preview https://deploy-preview-1772--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 2e6cacd
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63721cc41514420008a63e2b
😎 Deploy Preview https://deploy-preview-1772--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 4cad33e into main Nov 14, 2022
@kodiakhq kodiakhq bot deleted the mk/no-source-map branch November 14, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants